brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <>
Subject [GitHub] incubator-brooklyn pull request: BROOKLYN-49: Catalogue persistenc...
Date Mon, 22 Sep 2014 16:20:18 GMT
Github user sjcorbett commented on a diff in the pull request:
    --- Diff: core/src/main/java/brooklyn/catalog/internal/ ---
    @@ -472,4 +549,38 @@ private synchronized void loadSerializer() {
                 serializer = new CatalogXmlSerializer();
    \ No newline at end of file
    +    public void resetCatalogToContentsAtConfiguredUrl() {
    --- End diff --
    Agreed, it isn't great. The method was originally in `AbstractManagementContext`, so the
fallback made more sense. The method below is now called by `RebindManagerImpl` too. Perhaps
the method should be renamed so its behaviour is clearer. Any thoughts?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message