brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: BROOKLYN-49: Catalogue persistenc...
Date Fri, 19 Sep 2014 16:24:55 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/175#discussion_r17794350
  
    --- Diff: api/src/main/java/brooklyn/catalog/CatalogItem.java ---
    @@ -19,17 +19,20 @@
     package brooklyn.catalog;
     
     import java.util.List;
    -
     import javax.annotation.Nonnull;
     import javax.annotation.Nullable;
     
    +import com.google.common.annotations.Beta;
    +
    +import brooklyn.basic.BrooklynObject;
    +import brooklyn.entity.rebind.RebindSupport;
    +import brooklyn.entity.rebind.Rebindable;
     import brooklyn.management.ManagementContext;
     import brooklyn.management.classloading.BrooklynClassLoadingContext;
    -
    -import com.google.common.annotations.Beta;
    +import brooklyn.mementos.CatalogItemMemento;
     
     @Beta
    -public interface CatalogItem<T,SpecT> {
    +public interface CatalogItem<T,SpecT> extends BrooklynObject, Rebindable {
         
         public static enum CatalogItemType {
             TEMPLATE, ENTITY, POLICY, CONFIGURATION
    --- End diff --
    
    Templates are intended to denote applications. You're right that it determines what's
presented where in the web ui. Agreed enricher should be added. I think configuration has
been wrong the entire time it's there - CatalogResource as had `// FIXME configurations/ not
supported` as long as I can remember.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message