brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] incubator-brooklyn pull request: BROOKLYN-49: Catalogue persistenc...
Date Fri, 19 Sep 2014 14:55:30 GMT
Github user aledsage commented on a diff in the pull request:
    --- Diff: core/src/main/java/brooklyn/catalog/internal/ ---
    @@ -53,11 +54,12 @@
         List<CatalogDo> childrenCatalogs = new ArrayList<CatalogDo>();
         CatalogClasspathDo classpath;
         Map<String, CatalogItemDo<?,?>> cache;
    +    Map<String, CatalogItemDo<?,?>> registeredTypeNameCache;
    --- End diff --
    Is the original `cache` key'ed by id? I'd probably prefer names like `cacheById` and `cacheByRegisteredTypeName`.
No strong feelings.
    I'd also make these `private` so we can better reason about what is maintaining the cache.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message