brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: BROOKLYN-49: Catalogue persistenc...
Date Fri, 19 Sep 2014 14:51:43 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/175#discussion_r17788813
  
    --- Diff: core/src/main/java/brooklyn/catalog/internal/BasicBrooklynCatalog.java ---
    @@ -472,4 +549,38 @@ private synchronized void loadSerializer() {
                 serializer = new CatalogXmlSerializer();
         }
     
    -}
    \ No newline at end of file
    +    public void resetCatalogToContentsAtConfiguredUrl() {
    --- End diff --
    
    I'd probably prefer passing in the URL to this method, rather than `...AtConfiguredUrl()`.
But I guess that's trickier to avoid duplication, given the fallback logic here to do `newDefaultLocalScanningDto`?
On the other hand, perhaps that should be the caller's decision?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message