brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Refactors tests to work around In...
Date Fri, 19 Sep 2014 13:44:32 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/166#discussion_r17784612
  
    --- Diff: core/src/test/java/brooklyn/entity/hello/LocalEntitiesTest.java ---
    @@ -266,7 +266,7 @@ public void testConfigSetFromAttributeWhenReadyNullTransformations()
{
             app.setConfig(HelloEntity.MY_NAME, "Bob");
             
             HelloEntity dad = app.createAndManageChild(EntitySpec.create(HelloEntity.class));
    -        HelloEntity son = entityManager.createEntity(EntitySpec.create(HelloEntity.class)
    +        HelloEntity son = (HelloEntity)entityManager.createEntity(EntitySpec.create(HelloEntity.class)
    --- End diff --
    
    I'd have included a comment to say that cast is there for IntelliJ. Otherwise it risks
being removed by someone (or at least distracting them) at some point in the future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message