brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: BrooklynNode entity safe STOP eff...
Date Mon, 15 Sep 2014 15:51:50 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/161#discussion_r17550071
  
    --- Diff: usage/rest-api/src/main/java/brooklyn/rest/api/ServerApi.java ---
    @@ -53,7 +53,8 @@
         @Consumes({MediaType.APPLICATION_FORM_URLENCODED})
         public void shutdown(
             @FormParam("stopAppsFirst") @DefaultValue("false") boolean stopAppsFirst,
    -        @FormParam("delayMillis") @DefaultValue("250") long delayMillis);
    +        @FormParam("delayMillis") @DefaultValue("250") long delayMillis,
    --- End diff --
    
    Changed timeoutMillis to httpReturnTimeout  so it is compatible with your proposal. I'd
like to address the rest of the comment in a separate PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message