brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: BrooklynNode entity safe STOP eff...
Date Mon, 15 Sep 2014 08:07:41 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/161#discussion_r17529893
  
    --- Diff: software/base/src/test/java/brooklyn/entity/brooklynnode/SameBrooklynNodeImpl.java
---
    @@ -83,4 +83,9 @@ protected void disconnectSensors() {
             if (httpFeed != null) httpFeed.stop();
         }
     
    +    @Override
    +    public EntityHttpClient http() {
    --- End diff --
    
    i like the extraction of the `http()` as a convenience method.  however would throwing
`UnsupportedOperationException` be safer in this test class?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message