brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: fix/BROOKLYN-36
Date Fri, 12 Sep 2014 08:56:46 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/62#discussion_r17469260
  
    --- Diff: utils/common/src/main/java/brooklyn/util/ssh/IptablesCommands.java ---
    @@ -87,15 +89,20 @@ public static String iptablesServiceStatus() {
         }
     
         /**
    -     * Returns the command that saves on disk iptables rules, to make them resilient
to reboot.
    +     * Returns the command that saves iptables rules on file.
    +     *
    +     * @return Returns the command that saves iptables rules on file.
          *
    -     * @return Returns the command that saves on disk iptables rules.
          */
         public static String saveIptablesRules() {
    -        return BashCommands.alternatives(
    -                BashCommands.ifExecutableElse1("iptables-save", sudo("iptables-save")),
    -                iptablesService("save"));
    -    }
    +        return alternatives(sudo("service iptables save"), installPackage("iptables-persistent"));
    --- End diff --
    
    Do you still need to do `service iptables save` after installing `iptables-persistent`?
I presume installing the package will not automatically have saved the rules?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message