brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] incubator-brooklyn pull request: fix/BROOKLYN-36
Date Fri, 12 Sep 2014 08:53:12 GMT
Github user aledsage commented on a diff in the pull request:
    --- Diff: utils/common/src/main/java/brooklyn/util/ssh/ ---
    @@ -87,15 +89,20 @@ public static String iptablesServiceStatus() {
    -     * Returns the command that saves on disk iptables rules, to make them resilient
to reboot.
    +     * Returns the command that saves iptables rules on file.
    +     *
    +     * @return Returns the command that saves iptables rules on file.
    --- End diff --
    Personal preference: no need to repeat the same words for the method description + return
description. And the return description doesn't need to start with the word "Returns".

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message