brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: GUI+REST improvements - yaml spec...
Date Tue, 09 Sep 2014 16:57:17 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/156#discussion_r17313594
  
    --- Diff: usage/jsgui/src/test/javascript/specs/view/entity-details-spec.js ---
    @@ -89,13 +89,14 @@ define([
                 view.render();
             });
     
    -        it('must render textarea contents', function () {
    -            expect(view.$("textarea").length).toBe(1);
    -            expect(view.$("textarea").val()).toMatch("Tomcat");
    -        });
    +        // TODO textarea only appears if it's got yaml
    +//        it('must render textarea contents', function () {
    --- End diff --
    
    makes sense here, because the textarea is gone.
    
    elsewhere i've left test cases commented out which were too hard to make working, thinking
it's more likely we'll resuscitate them from comments than from git history.  no strong feelings
though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message