brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: GUI+REST improvements - yaml spec...
Date Tue, 09 Sep 2014 14:17:03 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/156#discussion_r17302482
  
    --- Diff: usage/jsgui/src/main/webapp/assets/js/view/entity-config.js ---
    @@ -22,146 +22,473 @@
      * @type {*}
      */
     define([
    -    "underscore", "jquery", "backbone", "brooklyn-utils",
    -    "view/viewutils", "model/config-summary", "text!tpl/apps/config.html",
    +    "underscore", "jquery", "backbone", "brooklyn-utils", "zeroclipboard", "view/viewutils",

    +    "model/config-summary", "text!tpl/apps/config.html", "text!tpl/apps/config-name.html",
         "jquery-datatables", "datatables-extensions"
    -], function (_, $, Backbone, Util, ViewUtils, ConfigSummary, ConfigHtml) {
    +], function (_, $, Backbone, Util, ZeroClipboard, ViewUtils, ConfigSummary, ConfigHtml,
ConfigNameHtml) {
     
    +    // TODO consider extracting all such usages to a shared ZeroClipboard wrapper?
    +    ZeroClipboard.config({ moviePath: 'assets/js/libs/ZeroClipboard.swf' });
    +
    +    var configHtml = _.template(ConfigHtml),
    +        configNameHtml = _.template(ConfigNameHtml);
    +
    +    // TODO refactor to share code w entity-sensors.js
    +    // in meantime, see notes there!
         var EntityConfigView = Backbone.View.extend({
    -        template:_.template(ConfigHtml),
    +        template: configHtml,
             configMetadata:{},
             refreshActive:true,
    +        zeroClipboard: null,
    +        
             events:{
                 'click .refresh':'refreshNow',
                 'click .filterEmpty':'toggleFilterEmpty',
    -            'click .toggleAutoRefresh':'toggleAutoRefresh'
    +            'click .toggleAutoRefresh':'toggleAutoRefresh',
    +
    +            'mouseup .valueOpen':'valueOpen',
    +            'mouseover #config-table tbody tr':'noteFloatMenuActive',
    +            'mouseout #config-table tbody tr':'noteFloatMenuSeemsInactive',
    +            'mouseover .floatGroup':'noteFloatMenuActive',
    +            'mouseout .floatGroup':'noteFloatMenuSeemsInactive',
    +            'mouseover .clipboard-item':'noteFloatMenuActiveCI',
    +            'mouseout .clipboard-item':'noteFloatMenuSeemsInactiveCI',
    +            'mouseover .hasFloatLeft':'showFloatLeft',
    +            'mouseover .hasFloatDown':'enterFloatDown',
    +            'mouseout .hasFloatDown':'exitFloatDown',
    +            'mouseup .light-popup-menu-item':'closeFloatMenuNow',
    --- End diff --
    
    Seems the events are a bit askew. When I try to use the float menu:
    * I place my mouse over the down arrow.
    * The menu appears.
    * I move the mouse to the first menu entry.
    * The menu disappears!
    * I move the mouse to the down arrow again.
    * The menu reappears.
    * I can move the mouse to and select the first entry.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message