brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: GUI+REST improvements - yaml spec...
Date Tue, 09 Sep 2014 13:45:42 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/156#discussion_r17300407
  
    --- Diff: usage/camp/src/main/java/io/brooklyn/camp/brooklyn/spi/creation/BrooklynYamlTypeInstantiator.java
---
    @@ -97,7 +97,8 @@ public InstantiatorFromKey prefix(String prefix) {
                     if (result.isAbsent()) result = data.getStringKeyMaybe("type");
                 }
                 
    -            if (result.isAbsent()) return Maybe.absent("Missing key '"+getPreferredKeyName()+"'");
    +            if (result.isAbsent() || result.get()==null) 
    --- End diff --
    
    Statements like this suggest we're missing the point of `Maybe`/`Optional`!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message