brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: BROOKLYN-51
Date Tue, 09 Sep 2014 08:50:30 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/154#discussion_r17288731
  
    --- Diff: usage/rest-server/src/main/java/brooklyn/rest/security/provider/BrooklynUserWithRandomPasswordSecurityProvider.java
---
    @@ -0,0 +1,58 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package brooklyn.rest.security.provider;
    +
    +import javax.servlet.http.HttpSession;
    +
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import brooklyn.management.ManagementContext;
    +import brooklyn.rest.security.BrooklynPropertiesSecurityFilter;
    +import brooklyn.util.text.Identifiers;
    +
    +public class BrooklynUserWithRandomPasswordSecurityProvider extends AbstractSecurityProvider
implements SecurityProvider {
    +
    +    public static final Logger LOG = LoggerFactory.getLogger(BrooklynUserWithRandomPasswordSecurityProvider.class);
    +    private static final String USER = "brooklyn";
    +    private final String password;
    +
    +    public BrooklynUserWithRandomPasswordSecurityProvider() {
    +        this.password = Identifiers.makeRandomId(10);
    +        LOG.info("Allowing access to web console from localhost or with {}:{}", USER,
password);
    --- End diff --
    
    I wonder if this should be a `sysout`, as well as a log. If a `sysout`, it should probably
be done by the caller so passing in the user+password. No particularly strong feelings.
    
    Wording would perhaps be improved if said `"or with auto-generated username and password
{}:{}"`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message