brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Start mirroring remote entities a...
Date Fri, 05 Sep 2014 21:27:43 GMT
Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/150#issuecomment-54683772
  
    Looks sensible. Only the one question about `setExpectedState`, then I'm happy to merge.
    
    It's a general concern if we're going to do more in `init` (e.g. calling `connectSensors()`
from inside `init` for more entities) if that might access config and thus block. If we're
going to do that, is the `connectSensorsAsync` the right general approach or should we call
it from elsewhere? The reason for doing it in `init` is because the enrichers+policies it
creates will be persisted, so we don't want to it to be done again on rebind. However, if
it was `async` then it might not have been done at all (e.g. if the config was taking a long
time to be set). Worth more thought for what our general approach is for this before we use
it in lots of other places, I think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message