brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aetomala <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: First iteration brooklyn web mobi...
Date Tue, 02 Sep 2014 13:39:43 GMT
Github user aetomala commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/130#discussion_r16986798
  
    --- Diff: usage/jsgui/src/main/webapp/assets/mobile/js/controllers.js ---
    @@ -0,0 +1,202 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *  http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    +*/
    +var bklnControllers = angular.module('BrooklynApp.controllers',['ngResource']);
    +
    +//Brooklyn ApplicationList controller
    +bklnControllers.controller('ApplicationListController', function($scope, $interval, ApplicationService){
    +	//
    +	$scope.reloadTimer;
    +	$scope.loadData = function(){
    +		ApplicationService.query({}, function (applications){
    +			$scope.applications = applications;
    +			console.log('ApplicationListController: new data loaded');
    +		});
    +	};
    +	
    +	$scope.showDetails = function($event){
    --- End diff --
    
     $scope.showDetails = function($event){
    
    
    Is a piece of code for a functionality that was never fully implemented, I
    will remove until functionality is cooked.
    
    Angel Tomala-Reyes (°²ç÷¶ù ÍÐÂíÀ­ Èð˹)
    Senior Software Engineer, Advanced Cloud Technologies
    Global Technology Services, IBM Corporation
    15038 Union Turnpike 8F
    Flushing, NY 11367
    aetomala@us.ibm.com
    
    
    
    
    From:	Svetoslav <notifications@github.com>
    To:	apache/incubator-brooklyn
                <incubator-brooklyn@noreply.github.com>
    Cc:	Angel E Tomala Reyes/Poughkeepsie/IBM@IBMUS
    Date:	09/02/2014 08:38 AM
    Subject:	Re: [incubator-brooklyn] First iteration brooklyn web mobile
                app. (#130)
    
    
    
    In usage/jsgui/src/main/webapp/assets/mobile/js/controllers.js:
    
    
    > + * under the License.
    > +*/
    > +var bklnControllers = angular.module
    ('BrooklynApp.controllers',['ngResource']);
    > +
    > +//Brooklyn ApplicationList controller
    > +bklnControllers.controller('ApplicationListController', function($scope,
    $interval, ApplicationService){
    > +		 //
    > +		 $scope.reloadTimer;
    > +		 $scope.loadData = function(){
    > +		 		 ApplicationService.query({}, function
    (applications){
    > +		 		 		 $scope.applications = applications;
    > +		 		 		 console.log
    ('ApplicationListController: new data loaded');
    > +		 		 });
    > +		 };
    > +
    > +		 $scope.showDetails = function($event){
    
    
    
    Don't see the point of this method, could you explain.
    
    
    ¡ª
    Reply to this email directly or view it on GitHub.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message