brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aetomala <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: First iteration brooklyn web mobi...
Date Tue, 02 Sep 2014 13:37:12 GMT
Github user aetomala commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/130#discussion_r16986655
  
    --- Diff: usage/jsgui/src/main/webapp/assets/mobile/js/templates/applicationsList.html
---
    @@ -0,0 +1,72 @@
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    + http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +-->
    +
    +<div class="scrollable">
    +	<div class="scrollable-content">
    +		<div class="list-group">
    +			<div style="padding: 10px 0px 19px 0px;" class="list-group-item">
    +				<span style="font-size: 1.5em; font-weight: 400; padding-left: 15px">{{'APPLICATION_LIST_TITLE'
| translate}}</span>
    +				<!-- <div class="btn-group pull-right">
    +					<a href="{{$scope.loadData()}}" class="btn btn-navbar"> <i
    +						class="fa fa-refresh"></i>
    +					</a>
    +				</div> -->
    +			</div>
    +
    +			<div ng-if="applications.length == 0" class="list-group-item">
    +				<h5 class="list-group-item-text text-center">{{'NO_APPS_FOUND' | translate}}</h5>
    +			</div>
    +
    +			<div ng-repeat="application in applications"
    +				href="#{{application.links.entities}}/{{application.id}}"
    +				class="list-group-item">
    +				<a href="#{{application.links.entities}}/{{application.id}}" ng-show="!showActions"
ng-swipe-left="showDetails($event)">
    +					<i class="fa fa-chevron-right pull-right"></i>
    +					<h5 class="list-group-item-heading">{{application.spec.name}}</h5>
    +	
    +					<p class="list-group-item-text">
    +	
    +						<i ng-if="application.status == 'RUNNING'"
    +							class="fa fa-circle text-success"></i> <i
    +							ng-if="application.status == 'UNKNOWN'"
    +							class="fa fa-exclamation text-warning"></i> <i
    +							ng-if="application.status == 'STARTING'"
    +							class="fa fa-circle text-info"></i> {{application.status | Capitalize}}
    +					</p>
    +				</a>
    +				
    +				<a href="#{{application.links.entities}}/{{application.id}}" ng-show="showActions"
ng-swipe-right="showActions = false">
    --- End diff --
    
    Looks like this is a piece of code left behind from a functionality as I
    was trying to allow the user to swipe left to reveal show details action
    rather than drill into the application/entity to later click on a details
    icon.  I will remove until feature is implemented fully.
    
    Angel Tomala-Reyes (°²ç÷¶ù ÍÐÂíÀ­ Èð˹)
    Senior Software Engineer, Advanced Cloud Technologies
    Global Technology Services, IBM Corporation
    15038 Union Turnpike 8F
    Flushing, NY 11367
    aetomala@us.ibm.com
    
    
    
    
    From:	Svetoslav <notifications@github.com>
    To:	apache/incubator-brooklyn
                <incubator-brooklyn@noreply.github.com>
    Cc:	Angel E Tomala Reyes/Poughkeepsie/IBM@IBMUS
    Date:	09/02/2014 08:38 AM
    Subject:	Re: [incubator-brooklyn] First iteration brooklyn web mobile
                app. (#130)
    
    
    
    In
    usage/jsgui/src/main/webapp/assets/mobile/js/templates/applicationsList.html:
    
    
    > +		 		 		 		 <a
    href="#{{application.links.entities}}/{{application.id}}"
    ng-show="!showActions" ng-swipe-left="showDetails($event)">
    > +		 		 		 		 		 <i class="fa
    fa-chevron-right pull-right"></i>
    > +		 		 		 		 		 <h5
    class="list-group-item-heading">{{application.spec.name}}</h5>
    > +
    > +		 		 		 		 		 <p
    class="list-group-item-text">
    > +
    > +		 		 		 		 		 		 <i
    ng-if="application.status == 'RUNNING'"
    > +
    	 class="fa fa-circle text-success"></i> <i
    > +
    	 ng-if="application.status == 'UNKNOWN'"
    > +
    	 class="fa fa-exclamation text-warning"></i> <i
    > +
    	 ng-if="application.status == 'STARTING'"
    > +
    	 class="fa fa-circle text-info"></i> {{application.status |
    Capitalize}}
    > +		 		 		 		 		 </p>
    > +		 		 		 		 </a>
    > +
    > +		 		 		 		 <a
    href="#{{application.links.entities}}/{{application.id}}"
    ng-show="showActions" ng-swipe-right="showActions = false">
    
    
    
    Where is showActions set to true, is this element ever visible?
    
    
    ¡ª
    Reply to this email directly or view it on GitHub.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message