brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nakomis <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Couchbase
Date Tue, 02 Sep 2014 12:32:35 GMT
Github user Nakomis commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/137#issuecomment-54144321
  
    A couple of comments about null / absent values in Maps or Iterables, but
    other than that, looks good. I particularly like the new $brooklyn:parent()
    etc - I was never a fan of $brooklyn:component("parent",
    "thisParameterDoesNothing")
    
    
    On 1 September 2014 17:16, Alex Heneveld <notifications@github.com> wrote:
    
    > merging this, the majority of it is my review of #1
    > <https://github.com/apache/incubator-brooklyn/pull/1> and #25
    > <https://github.com/apache/incubator-brooklyn/pull/25>, and we have
    > people actively wanting to use the couchbase support.
    >
    > however @Nakomis <https://github.com/Nakomis> i wouldn't mind a review of
    > these commits:
    >
    >    - ahgittin@05a3948
    >    <https://github.com/ahgittin/incubator-brooklyn/commit/05a39488dca27887f563c20ad1110ed3916c25f5>
    >    - ahgittin@c6d6cc4
    >    <https://github.com/ahgittin/incubator-brooklyn/commit/c6d6cc4aa3800ac361b55956abe10f9dc8dfe7dc>
    >    - ahgittin@1064cd5
    >    <https://github.com/ahgittin/incubator-brooklyn/commit/1064cd5df9cd3c49856efea7a1622745b0dd4ea6>
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/incubator-brooklyn/pull/137#issuecomment-54076058>
    > .
    >
    
    
    
    -- 
    Martin Harris
    Lead Software Engineer
    Cloudsoft Corporation Ltd
    www.cloudsoftcorp.com
    Mobile: +44 (0)7989 047-855


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message