Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
Date: Tue, 5 Aug 2014 13:52:12 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@brooklyn.incubator.apache.org
Message-ID: <JIRA.12724445.1404137005607.17081.1407246732943@arcas>
In-Reply-To: <JIRA.12724445.1404137005607@arcas>
References: <JIRA.12724445.1404137005607@arcas>
Subject: [jira] [Commented] (BROOKLYN-12) Add Node.JS application support
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/BROOKLYN-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086280#comment-14086280 ] 

ASF GitHub Bot commented on BROOKLYN-12:
----------------------------------------

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/94#discussion_r15812712
  
    --- Diff: software/webapp/src/test/java/brooklyn/entity/webapp/nodejs/NodeJsWebAppSimpleIntegrationTest.java ---
    @@ -0,0 +1,100 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package brooklyn.entity.webapp.nodejs;
    +
    +import static org.testng.Assert.assertFalse;
    +import static org.testng.Assert.fail;
    +
    +import java.net.ServerSocket;
    +import java.util.Iterator;
    +
    +import org.jclouds.util.Throwables2;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +import org.testng.annotations.AfterMethod;
    +import org.testng.annotations.BeforeMethod;
    +import org.testng.annotations.Test;
    +
    +import brooklyn.entity.basic.ApplicationBuilder;
    +import brooklyn.entity.basic.Entities;
    +import brooklyn.entity.proxying.EntitySpec;
    +import brooklyn.location.PortRange;
    +import brooklyn.location.basic.LocalhostMachineProvisioningLocation;
    +import brooklyn.location.basic.PortRanges;
    +import brooklyn.test.entity.TestApplication;
    +import brooklyn.util.net.Networking;
    +
    +import com.google.common.collect.ImmutableList;
    +
    +/**
    + * This tests the operation of the {@link NodeJsWebAppService} entity.
    + *
    + * FIXME this test is largely superseded by WebApp*IntegrationTest which tests inter alia Tomcat
    + */
    +public class NodeJsWebAppSimpleIntegrationTest {
    --- End diff --
    
    Test fails on OS X - no brew or port equivalents for install. Need to document that somewhere (perhaps both here in the test, and on the javadoc of the entity itself).


> Add Node.JS application support
> -------------------------------
>
>                 Key: BROOKLYN-12
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-12
>             Project: Brooklyn
>          Issue Type: New Feature
>         Environment: Linux
>            Reporter: Andrew Kennedy
>            Assignee: Andrew Kennedy
>
> Create entities and blueprints to deploy and manage Node.JS applications and clustered services.


--
This message was sent by Atlassian JIRA
(v6.2#6252)