Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: grkvlt <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-133-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-133-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Lifecycle Enhancements
Content-Type: text/plain
Message-Id: <20140829161721.D7740956C0E@tyr.zones.apache.org>
Date: Fri, 29 Aug 2014 16:17:21 +0000 (UTC)

Github user grkvlt commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/133#discussion_r16906451
  
    --- Diff: core/src/main/java/brooklyn/entity/group/DynamicClusterImpl.java ---
    @@ -749,6 +759,18 @@ protected Entity addNode(Location loc, Map<?,?> extraFlags) {
             }
     
             Entity entity = createNode(loc, createFlags);
    +
    +        ((EntityLocal) entity).setAttribute(CLUSTER_MEMBER, true);
    +        ((EntityLocal) entity).setAttribute(CLUSTER, this);
    --- End diff --
    
    Good question! I guess no, because the relation is based on being a *child* of only one cluster whereas you can be a *member* of many groups.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---