Return-Path: X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B026911158 for ; Fri, 29 Aug 2014 15:48:38 +0000 (UTC) Received: (qmail 1063 invoked by uid 500); 29 Aug 2014 15:48:38 -0000 Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org Received: (qmail 1027 invoked by uid 500); 29 Aug 2014 15:48:38 -0000 Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@brooklyn.incubator.apache.org Delivered-To: mailing list dev@brooklyn.incubator.apache.org Received: (qmail 1008 invoked by uid 99); 29 Aug 2014 15:48:38 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Aug 2014 15:48:38 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 29 Aug 2014 15:48:15 +0000 Received: (qmail 531 invoked by uid 99); 29 Aug 2014 15:48:13 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Aug 2014 15:48:13 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 2E457956B7F; Fri, 29 Aug 2014 15:48:13 +0000 (UTC) From: neykov To: dev@brooklyn.incubator.apache.org Reply-To: dev@brooklyn.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-brooklyn pull request: Sensors chained for service up Content-Type: text/plain Message-Id: <20140829154813.2E457956B7F@tyr.zones.apache.org> Date: Fri, 29 Aug 2014 15:48:13 +0000 (UTC) X-Virus-Checked: Checked by ClamAV on apache.org Github user neykov commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/131#issuecomment-53893777 There are lots of TODO comments related to concurrency/synchronization issues with the code, should they be addressed before merging? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---