Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: neykov <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-131-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-131-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Sensors chained for service
 up
Content-Type: text/plain
Message-Id: <20140829114214.9AF6E9561EC@tyr.zones.apache.org>
Date: Fri, 29 Aug 2014 11:42:14 +0000 (UTC)

Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/131#discussion_r16893523
  
    --- Diff: utils/common/src/main/java/brooklyn/util/guava/IfFunctions.java ---
    @@ -0,0 +1,158 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package brooklyn.util.guava;
    +
    +import java.util.LinkedHashMap;
    +import java.util.Map;
    +
    +import com.google.common.annotations.Beta;
    +import com.google.common.base.Function;
    +import com.google.common.base.Functions;
    +import com.google.common.base.Predicate;
    +import com.google.common.base.Predicates;
    +import com.google.common.base.Supplier;
    +
    +/** Utilities for building {@link Function} instances which return specific values
    + * (or {@link Supplier} or {@link Function} instances) when certain predicates are satisfied,
    + * tested in order and returning the first matching,
    + * with support for an "else" default value if none are satisfied (null by default). */
    +public class IfFunctions {
    +
    +    public static <I,O> IfFunctionBuilder<I,O> newInstance(Class<I> testType, Class<O> returnType) {
    +        return new IfFunctionBuilder<I,O>();
    +    }
    +    
    +    public static <I,O> IfFunctionBuilderApplyingFirst<I> ifPredicate(Predicate<? super I> test) {
    +        return new IfFunctionBuilderApplyingFirst<I>(test);
    +    }
    +    public static <I,O> IfFunctionBuilderApplyingFirst<I> ifEquals(I test) {
    +        return ifPredicate(Predicates.equalTo(test));
    +    }
    +    public static <I,O> IfFunctionBuilderApplyingFirst<I> ifNotEquals(I test) {
    --- End diff --
    
    Remove the O type parameter, unused (all three methods).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---