brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix BrooklyCatalog.createSpec, wa...
Date Fri, 29 Aug 2014 15:42:16 GMT
GitHub user neykov opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/135

    Fix BrooklyCatalog.createSpec, was creating the spec as if a regular app, not catalog
item.

    BrooklynAssemblyTemplateInstantiator.createSpec couldn't realize that the passed in plan
was created from a catalog item - it was checking with the wrong id (plan name instead of
catalog id). Fix the problem by passing a loader explicitly, making it the caller's responsibility
to decide if it is a catalog item plan or a regular plan.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/neykov/incubator-brooklyn osgi-fix-catalog-createspec

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/135.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #135
    
----
commit b2cc03ac081db664dfddfe1b2ae4acb209da01b0
Author: Svetoslav Neykov <svetoslav.neykov@cloudsoftcorp.com>
Date:   2014-08-29T15:41:01Z

    Fix BrooklyCatalog.createSpec, was creating the spec as if a regular app, not catalog
item.
    
    BrooklynAssemblyTemplateInstantiator.createSpec couldn't realize that the passed in plan
was created from a catalog item - it was checking with the wrong id (plan name instead of
catalog id). Fix the problem by passing a loader explicitly, making it the caller's responsibility
to decide if it is a catalog item plan or a regular plan.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message