brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grkvlt <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Lifecycle Enhancements
Date Fri, 29 Aug 2014 16:26:03 GMT
Github user grkvlt commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/133#discussion_r16906833
  
    --- Diff: software/base/src/main/java/brooklyn/entity/software/MachineLifecycleEffectorTasks.java
---
    @@ -403,26 +430,29 @@ public void restart() {
                 DynamicTasks.waitForLast();
                 return "Stop of process completed with no errors.";
             }});
    -        
    +
             DynamicTasks.queue("starting", new Runnable() { public void run() {
                 // startInLocations will look up the location, and provision a machine if
necessary
                 // (if it remembered the provisioning location)
                 entity().setAttribute(Attributes.SERVICE_STATE, Lifecycle.STARTING);
                 startInLocations(null);
                 DynamicTasks.waitForLast();
    -            if (entity().getAttribute(Attributes.SERVICE_STATE) == Lifecycle.STARTING)

    +            if (entity().getAttribute(Attributes.SERVICE_STATE) == Lifecycle.STARTING)
{
                     entity().setAttribute(Attributes.SERVICE_STATE, Lifecycle.RUNNING);
    +            }
             }});
         }
     
    -    // ---------------------
    -
    -    /** default stop impl, aborts if already stopped, otherwise sets state STOPPING then
    +    /**
    +     * Default stop implementation for an entity.
    +     * <p>
    +     * Aborts if already stopped, otherwise sets state {@link Lifecycle#STOPPING} then
    --- End diff --
    
    Heh, the Javadoc needs looked at in a lot of places, but there are a lot of more pressing
concerns.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message