brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Lifecycle Enhancements
Date Fri, 29 Aug 2014 15:57:48 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/133#discussion_r16905579
  
    --- Diff: software/base/src/main/java/brooklyn/entity/basic/SoftwareProcess.java ---
    @@ -33,65 +33,92 @@
     import brooklyn.util.flags.SetFromFlag;
     import brooklyn.util.time.Duration;
     
    +import com.google.common.reflect.TypeToken;
    +
     public interface SoftwareProcess extends Entity, Startable {
     
    -    public static final AttributeSensor<String> HOSTNAME = Attributes.HOSTNAME;
    -    public static final AttributeSensor<String> ADDRESS = Attributes.ADDRESS;
    -    public static final AttributeSensor<String> SUBNET_HOSTNAME = Attributes.SUBNET_HOSTNAME;
    -    public static final AttributeSensor<String> SUBNET_ADDRESS = Attributes.SUBNET_ADDRESS;
    +    AttributeSensor<String> HOSTNAME = Attributes.HOSTNAME;
    +    AttributeSensor<String> ADDRESS = Attributes.ADDRESS;
    +    AttributeSensor<String> SUBNET_HOSTNAME = Attributes.SUBNET_HOSTNAME;
    +    AttributeSensor<String> SUBNET_ADDRESS = Attributes.SUBNET_ADDRESS;
     
         @SetFromFlag("startTimeout")
    -    public static final ConfigKey<Duration> START_TIMEOUT = BrooklynConfigKeys.START_TIMEOUT;
    +    ConfigKey<Duration> START_TIMEOUT = BrooklynConfigKeys.START_TIMEOUT;
     
         @SetFromFlag("startLatch")
    -    public static final ConfigKey<Boolean> START_LATCH = BrooklynConfigKeys.START_LATCH;
    +    ConfigKey<Boolean> START_LATCH = BrooklynConfigKeys.START_LATCH;
    +
    +    @SetFromFlag("setupLatch")
    +    ConfigKey<Boolean> SETUP_LATCH = BrooklynConfigKeys.SETUP_LATCH;
     
         @SetFromFlag("installLatch")
    -    public static final ConfigKey<Boolean> INSTALL_LATCH = BrooklynConfigKeys.INSTALL_LATCH;
    +    ConfigKey<Boolean> INSTALL_LATCH = BrooklynConfigKeys.INSTALL_LATCH;
     
         @SetFromFlag("customizeLatch")
    -    public static final ConfigKey<Boolean> CUSTOMIZE_LATCH = BrooklynConfigKeys.CUSTOMIZE_LATCH;
    -    
    -    @SetFromFlag("preLaunchCommand")
    -    public static final ConfigKey<String> PRE_LAUNCH_COMMAND = BrooklynConfigKeys.PRE_LAUNCH_COMMAND;
    -    
    -    @SetFromFlag("postLaunchCommand")
    -    public static final ConfigKey<String> POST_LAUNCH_COMMAND = BrooklynConfigKeys.POST_LAUNCH_COMMAND;
    +    ConfigKey<Boolean> CUSTOMIZE_LATCH = BrooklynConfigKeys.CUSTOMIZE_LATCH;
    +
    +    @SetFromFlag("resourcesLatch")
    +    ConfigKey<Boolean> RESOURCES_LATCH = BrooklynConfigKeys.RESOURCES_LATCH;
     
         @SetFromFlag("launchLatch")
    -    public static final ConfigKey<Boolean> LAUNCH_LATCH = BrooklynConfigKeys.LAUNCH_LATCH;
    +    ConfigKey<Boolean> LAUNCH_LATCH = BrooklynConfigKeys.LAUNCH_LATCH;
    +
    +    @SetFromFlag("skipInstall")
    +    ConfigKey<Boolean> SKIP_INSTALLATION = BrooklynConfigKeys.SKIP_INSTALLATION;
    +
    +    @SetFromFlag("preInstallCommand")
    +    ConfigKey<String> PRE_INSTALL_COMMAND = BrooklynConfigKeys.PRE_INSTALL_COMMAND;
    +
    +    @SetFromFlag("postInstallCommand")
    +    ConfigKey<String> POST_INSTALL_COMMAND = BrooklynConfigKeys.POST_INSTALL_COMMAND;
    +
    +    @SetFromFlag("preLaunchCommand")
    +    ConfigKey<String> PRE_LAUNCH_COMMAND = BrooklynConfigKeys.PRE_LAUNCH_COMMAND;
    +
    +    @SetFromFlag("postLaunchCommand")
    +    ConfigKey<String> POST_LAUNCH_COMMAND = BrooklynConfigKeys.POST_LAUNCH_COMMAND;
     
         @SetFromFlag("version")
    -    public static final ConfigKey<String> SUGGESTED_VERSION = BrooklynConfigKeys.SUGGESTED_VERSION;
    +    ConfigKey<String> SUGGESTED_VERSION = BrooklynConfigKeys.SUGGESTED_VERSION;
     
         @SetFromFlag("downloadUrl")
    -    public static final BasicAttributeSensorAndConfigKey<String> DOWNLOAD_URL =
Attributes.DOWNLOAD_URL;
    +    BasicAttributeSensorAndConfigKey<String> DOWNLOAD_URL = Attributes.DOWNLOAD_URL;
    --- End diff --
    
    Could use `AttributeSensorAndConfigKey` for consistency


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message