brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Lifecycle Enhancements
Date Fri, 29 Aug 2014 15:55:07 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/133#discussion_r16905439
  
    --- Diff: software/base/src/main/java/brooklyn/entity/basic/AbstractSoftwareProcessDriver.java
---
    @@ -113,12 +143,20 @@ public void start() {
         @Override
         public abstract void stop();
     
    +    /**
    +     * Implement this method in child classes to add some post-launch behavior
    +     */
    +    public void preInstall() {}
    +
    +    public abstract void runPreInstallCommand(String command);
    +    public abstract void setup();
         public abstract void install();
    +    public abstract void runPostInstallCommand(String command);
         public abstract void customize();
    +    public abstract void resources();
    --- End diff --
    
    Not clear what `resources` is to be used for. The others are all understandable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message