brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: First iteration brooklyn web mobi...
Date Fri, 29 Aug 2014 14:18:46 GMT
Github user sjcorbett commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/130#issuecomment-53881504
  
    GitHub won't let me comment on `index.m.html` inline. A few comments:
    * Remove the hard-coded reference to `localhost:8081`
    * The user-agent matcher is pretty filmsy. What about all the Android users! 
    * Why is it commented out? Improve or delete.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message