brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Sensors chained for service up
Date Fri, 29 Aug 2014 12:28:20 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/131#discussion_r16894809
  
    --- Diff: core/src/main/java/brooklyn/enricher/basic/AbstractAggregator.java ---
    @@ -0,0 +1,215 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package brooklyn.enricher.basic;
    +
    +import static com.google.common.base.Preconditions.checkState;
    +
    +import java.util.Set;
    +
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import brooklyn.config.ConfigKey;
    +import brooklyn.entity.Entity;
    +import brooklyn.entity.Group;
    +import brooklyn.entity.basic.AbstractEntity;
    +import brooklyn.entity.basic.ConfigKeys;
    +import brooklyn.entity.basic.EntityLocal;
    +import brooklyn.entity.trait.Changeable;
    +import brooklyn.event.Sensor;
    +import brooklyn.event.SensorEvent;
    +import brooklyn.event.SensorEventListener;
    +import brooklyn.util.exceptions.Exceptions;
    +import brooklyn.util.guava.Maybe;
    +
    +import com.google.common.base.Predicate;
    +import com.google.common.base.Predicates;
    +import com.google.common.collect.Iterables;
    +import com.google.common.reflect.TypeToken;
    +
    +/** Abstract superclass for enrichers which aggregate from children and/or members */
    +@SuppressWarnings("serial")
    +public abstract class AbstractAggregator<T,U> extends AbstractEnricher implements
SensorEventListener<T> {
    +
    +    private static final Logger LOG = LoggerFactory.getLogger(AbstractAggregator.class);
    +
    +    public static final ConfigKey<Entity> PRODUCER = ConfigKeys.newConfigKey(Entity.class,
"enricher.producer", "The entity whose children/members will be aggregated");
    +
    +    public static final ConfigKey<Sensor<?>> TARGET_SENSOR = ConfigKeys.newConfigKey(new
TypeToken<Sensor<?>>() {}, "enricher.targetSensor");
    +
    +    // FIXME this is not just for "members" i think -Alex
    +    public static final ConfigKey<?> DEFAULT_MEMBER_VALUE = ConfigKeys.newConfigKey(Object.class,
"enricher.defaultMemberValue");
    +
    +    public static final ConfigKey<Set<? extends Entity>> FROM_HARDCODED_PRODUCERS
= ConfigKeys.newConfigKey(new TypeToken<Set<? extends Entity>>() {}, "enricher.aggregating.fromHardcodedProducers");
    +
    +    public static final ConfigKey<Boolean> FROM_MEMBERS = ConfigKeys.newBooleanConfigKey("enricher.aggregating.fromMembers");
    +
    +    public static final ConfigKey<Boolean> FROM_CHILDREN = ConfigKeys.newBooleanConfigKey("enricher.aggregating.fromChildren");
    +
    +    public static final ConfigKey<Predicate<? super Entity>> ENTITY_FILTER
= ConfigKeys.newConfigKey(new TypeToken<Predicate<? super Entity>>() {}, "enricher.aggregating.entityFilter");
    +
    +    public static final ConfigKey<Predicate<?>> VALUE_FILTER = ConfigKeys.newConfigKey(new
TypeToken<Predicate<?>>() {}, "enricher.aggregating.valueFilter");
    +
    +    protected Entity producer;
    +    protected Sensor<U> targetSensor;
    +    protected T defaultMemberValue;
    +    protected Set<? extends Entity> fromHardcodedProducers;
    +    protected Boolean fromMembers;
    +    protected Boolean fromChildren;
    +    protected Predicate<? super Entity> entityFilter;
    +    protected Predicate<? super T> valueFilter;
    +    
    +    public AbstractAggregator() {}
    +
    +    @Override
    +    public void setEntity(EntityLocal entity) {
    +        super.setEntity(entity);
    +        setEntityLoadingConfig();
    +
    +        if (fromHardcodedProducers == null && producer == null) producer = entity;
    +        checkState(fromHardcodedProducers != null ^ producer != null, "must specify one
of %s (%s) or %s (%s)", 
    +                PRODUCER.getName(), producer, FROM_HARDCODED_PRODUCERS.getName(), fromHardcodedProducers);
    +        checkState(producer != null ? (Boolean.TRUE.equals(fromMembers) || Boolean.TRUE.equals(fromChildren))
: true, 
    --- End diff --
    
    Better use boolean expression: producer == null || (Boolean.TRUE.equals(fromMembers) ||
Boolean.TRUE.equals(fromChildren)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message