brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Sensors chained for service up
Date Fri, 29 Aug 2014 12:18:42 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/131#discussion_r16894503
  
    --- Diff: usage/rest-api/src/main/java/brooklyn/rest/api/PolicyApi.java ---
    @@ -57,6 +57,7 @@
       @GET
       @Path("/current-state")
       @ApiOperation(value = "Fetch policy states in batch", notes="Returns a map of policy
ID to whether it is active")
    +  // FIXME method name -- this is nothing to do with config!
    --- End diff --
    
    Better just to rename it. The REST API method names are not exposed to clients.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message