brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Minor misc tidies
Date Mon, 25 Aug 2014 06:32:31 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/113#discussion_r16643506
  
    --- Diff: core/src/test/java/brooklyn/entity/basic/DynamicEntityTest.java ---
    @@ -35,7 +36,7 @@
         
         @BeforeMethod(alwaysRun=true)
         public void setup() throws Exception {
    -        app = ApplicationBuilder.newManagedApp(EntitySpec.create(BasicApplication.class));
    +        app = ApplicationBuilder.newManagedApp(EntitySpec.create(BasicApplication.class),
LocalManagementContextForTests.newInstance());
    --- End diff --
    
    +1 -- i'd be in favour of removing `ApplicationBuilder`.  the `TestApp.Factory` call feels
good for most test uses.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message