brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: brooklyn.properties permissions c...
Date Thu, 14 Aug 2014 10:42:15 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/115#discussion_r16231372
  
    --- Diff: usage/launcher/src/test/java/brooklyn/launcher/BrooklynLauncherTest.java ---
    @@ -219,6 +221,7 @@ public void testReloadBrooklynPropertiesRestoresProgrammaticProperties()
throws
         @Test
         public void testReloadBrooklynPropertiesFromFile() throws Exception {
             File globalPropertiesFile = File.createTempFile("local-brooklyn-properties-test",
".properties");
    +        FileUtil.setFilePermissionsTo600(globalPropertiesFile);
    --- End diff --
    
    `FileUtil` (and thus these methods) was added in PR #114 
    
    Problem is its implementation is based on `File.setReadable(boolean readable, boolean
ownerOnly)`, so it would need to interpret the hex and make appropriate set of calls. And
then we'd throw away the code when we can use Java 7. Let's refactor when we have more than
a requirement for `setFilePermissionsTo600` and `setFilePermissionsTo700` - they are both
marked `@Beta`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message