brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Minor misc tidies
Date Tue, 12 Aug 2014 13:55:20 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/113#discussion_r16113837
  
    --- Diff: core/src/main/java/brooklyn/util/osgi/Osgis.java ---
    @@ -195,7 +196,22 @@ private static void installBootBundles(Framework framework) {
             Map<String, Bundle> installedBundles = getInstalledBundles(bundleContext);
             while(resources.hasMoreElements()) {
                 URL url = resources.nextElement();
    -            installExtensionBundle(bundleContext, url, installedBundles, getVersionedId(framework));
    +            ReferenceWithError<Boolean> installResult = installExtensionBundle(bundleContext,
url, installedBundles, getVersionedId(framework));
    +            if (installResult.hasError()) {
    +                if (installResult.getMaskingError()) {
    +                    // true return code means it was installed or trivially not installed
    +                    if (LOG.isTraceEnabled())
    +                        LOG.trace(installResult.getError().getMessage());
    --- End diff --
    
    The message could presumably be `null`, and might also not indicate what the exception
type was? Should we instead do toString() on the error? Same below.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message