brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: add uniqueTag and tags for all ad...
Date Thu, 07 Aug 2014 09:36:02 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/106#discussion_r15926112
  
    --- Diff: utils/common/src/main/java/brooklyn/util/guava/Functionals.java ---
    @@ -38,4 +43,20 @@
             return chain(f1, chain(f2, chain(f3, f4)));
         }
     
    +    public static <I> WhenFunctionBuilderWhenFirst<I> when(I test) {
    +        return WhenFunctions.when(test);
    --- End diff --
    
    I'd prefer this to be called `whenEquals`, doing WhenFunctions.when(`Predicates.equalTo(test))`
explicitly. I don't like that it accepts Object and then behaves differently in the constructor
for whether it is a Predicate or not.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message