brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: improve startup logging
Date Thu, 07 Aug 2014 09:24:12 GMT
Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/109#issuecomment-51449484
  
    For commit bf627f7, it looks sensible. A couple of minor comments that you can ignore
:-) :
    * I generally avoid things like `LOG.warn("Error...` because it's not a `java.lang.Error`.
I normally say "Problem...".
    * In a method `private static void installExtensionBundle` I would generally expect it
to either install or to throw an exception. Particularly when it's only called in one place,
then perhaps the responsibility for the try-catch should be in the caller. However, to get
a sensible error about what went wrong would require more code so no strong feelings - fine
with code as-is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message