brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: BROOKLYN-12 Node.JS Entity
Date Tue, 05 Aug 2014 13:06:55 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/94#discussion_r15810286
  
    --- Diff: software/webapp/src/main/java/brooklyn/entity/webapp/JavaWebAppSoftwareProcessImpl.java
---
    @@ -178,33 +176,4 @@ protected void doStop() {
             setAttribute(REQUESTS_PER_SECOND_LAST, 0D);
             setAttribute(REQUESTS_PER_SECOND_IN_WINDOW, 0D);
         }
    -    
    -    protected Set<String> getEnabledProtocols() {
    -        return getAttribute(JavaWebAppSoftwareProcess.ENABLED_PROTOCOLS);
    -    }
    -    
    -    protected boolean isProtocolEnabled(String protocol) {
    -        for (String contender : getEnabledProtocols()) {
    -            if (protocol.equalsIgnoreCase(contender)) {
    -                return true;
    -            }
    -        }
    -        return false;
    -    }
    -    
    -    protected String inferBrooklynAccessibleRootUrl() {
    --- End diff --
    
    Did nothing use this method?! 
    
    Should we change things like:
    
        HostAndPort accessible = BrooklynAccessUtils.getBrooklynAccessibleAddress(this, getAttribute(HTTP_PORT));
        String nodeJsUrl = String.format("http://%s:%d", accessible.getHostText(), accessible.getPort());
    
    to use it instead, or should we deprecate it and go with the pattern used elsewhere?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message