brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: add uniqueTag and tags for all ad...
Date Tue, 05 Aug 2014 11:16:53 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/106#discussion_r15806246
  
    --- Diff: core/src/main/java/brooklyn/entity/proxying/InternalLocationFactory.java ---
    @@ -95,7 +95,9 @@ public InternalLocationFactory(ManagementContextInternal managementContext)
{
                 managementContext.prePreManage(loc);
     
                 if (spec.getDisplayName()!=null)
    -                ((AbstractLocation)loc).setName(spec.getDisplayName());
    +                ((AbstractLocation)loc).setDisplayName(spec.getDisplayName());
    +            
    +            ((AbstractLocation)loc).addTags(spec.getTags());
    --- End diff --
    
    Note that I have some work-in-progress to move much of this into a common `InternalFactory`,
to remove the duplication between `InternalEntityFactory`, `InternalPolicyFactory` and `InternalLocationFactory`.
(Doesn't affect this PR though).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message