brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix enrichers too much rebinded
Date Fri, 01 Aug 2014 16:34:21 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/101#discussion_r15705360
  
    --- Diff: core/src/main/java/brooklyn/util/file/ArchiveBuilder.java ---
    @@ -206,21 +221,33 @@ public ArchiveBuilder addDir(String dirName) {
     
         /**
          * Add the contents of the directory {@code dir} to the archive.
    +     * The directory's name is not included; use {@link #addAtRoot(File)} if you want
that behaviour. 
          * <p>
          * Uses {@literal .} as the parent directory name for the contents.
          *
          * @see #entry(String, File)
          */
    -    public ArchiveBuilder addDir(File dir) {
    +    public ArchiveBuilder addDirContentsAt(File dir, String archiveParentDir) {
    --- End diff --
    
    Note that `ArchiveBuilder` was added in 0.7.0-M1.
    I suggest we add `@Beta`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message