Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: ahgittin <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-90-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-90-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: OSGi class loading fixes
Content-Type: text/plain
Message-Id: <20140725185632.CDA0E9B5683@tyr.zones.apache.org>
Date: Fri, 25 Jul 2014 18:56:32 +0000 (UTC)

Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/90#discussion_r15418319
  
    --- Diff: core/src/main/java/brooklyn/management/ha/OsgiManager.java ---
    @@ -120,6 +131,11 @@ public void registerBundle(String bundleUrl) {
                 } catch (Exception e) {
                     Exceptions.propagateIfFatal(e);
                     bundleProblems.put(bundleUrlOrNameVersionString, e);
    +
    +                Throwable cause = e.getCause();
    +                if (cause != null && cause.getMessage().contains("Unresolved constraint in bundle")) {
    +                    log.warn("Unresolved constraint.", e);
    --- End diff --
    
    stack trace probably not helpful, so I would say
    
        log.warn("Unresolved constraint resolving OSGi bundle "+bundleUrlOrNameVersionString+" to load "+type+": "+e);
        if (log.isDebugEnabled()) log.debug("Trace for OSGi resolution failure", e);


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---