Return-Path: 
 <dev-return-688-apmail-brooklyn-dev-archive=brooklyn.apache.org@brooklyn.incubator.apache.org>
X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 7E836109F6
	for <apmail-brooklyn-dev-archive@minotaur.apache.org>;
 Wed,  9 Jul 2014 15:58:28 +0000 (UTC)
Received: (qmail 83391 invoked by uid 500); 9 Jul 2014 15:58:28 -0000
Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org
Received: (qmail 83356 invoked by uid 500); 9 Jul 2014 15:58:28 -0000
Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@brooklyn.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@brooklyn.incubator.apache.org>
List-Post: <mailto:dev@brooklyn.incubator.apache.org>
List-Id: <dev.brooklyn.incubator.apache.org>
Reply-To: dev@brooklyn.incubator.apache.org
Delivered-To: mailing list dev@brooklyn.incubator.apache.org
Received: (qmail 83345 invoked by uid 99); 9 Jul 2014 15:58:28 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Jul 2014 15:58:28 +0000
X-ASF-Spam-Status: No, hits=-2000.7 required=5.0
	tests=ALL_TRUSTED,RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3)
    by apache.org (qpsmtpd/0.29) with SMTP; Wed, 09 Jul 2014 15:58:29 +0000
Received: (qmail 83167 invoked by uid 99); 9 Jul 2014 15:58:04 -0000
Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org)
 (140.211.11.114)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Jul 2014 15:58:04 +0000
Received: by tyr.zones.apache.org (Postfix, from userid 65534)
	id CB09B9A9C36; Wed,  9 Jul 2014 15:58:03 +0000 (UTC)
From: ahgittin <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-47-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-47-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: OSGi/catalog improvements
Content-Type: text/plain
Message-Id: <20140709155803.CB09B9A9C36@tyr.zones.apache.org>
Date: Wed,  9 Jul 2014 15:58:03 +0000 (UTC)
X-Virus-Checked: Checked by ClamAV on apache.org

Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/47#discussion_r14718026
  
    --- Diff: core/src/main/java/brooklyn/management/ha/OsgiManager.java ---
    @@ -102,4 +107,24 @@ public void registerBundle(String bundleUrl) {
             return Maybe.absent("Unable to resolve class "+type+": "+bundleProblems);
         }
     
    +    public URL getResource(String name, Iterable<String> bundleUrlsOrNameVersionString) {
    +        for (String bundleUrlOrNameVersionString: bundleUrlsOrNameVersionString) {
    +            try {
    +                String bundleNameVersion = bundleUrlToNameVersionString.get(bundleUrlOrNameVersionString);
    +                if (bundleNameVersion==null) {
    +                    bundleNameVersion = bundleUrlOrNameVersionString;
    +                }
    +                
    +                Maybe<Bundle> bundle = Osgis.getBundle(framework, bundleNameVersion);
    +                if (bundle.isPresent()) {
    +                    URL result = bundle.get().getResource(name);
    +                    if (result!=null) return result;
    +                }
    +            } catch (Throwable e) {
    --- End diff --
    
    sure


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---