Return-Path: X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BE7181098D for ; Wed, 9 Jul 2014 15:45:16 +0000 (UTC) Received: (qmail 42471 invoked by uid 500); 9 Jul 2014 15:45:16 -0000 Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org Received: (qmail 42440 invoked by uid 500); 9 Jul 2014 15:45:16 -0000 Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@brooklyn.incubator.apache.org Delivered-To: mailing list dev@brooklyn.incubator.apache.org Received: (qmail 42424 invoked by uid 99); 9 Jul 2014 15:45:16 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Jul 2014 15:45:16 +0000 X-ASF-Spam-Status: No, hits=-2000.7 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 09 Jul 2014 15:45:15 +0000 Received: (qmail 37778 invoked by uid 99); 9 Jul 2014 15:44:54 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Jul 2014 15:44:54 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id B48F69A9BEB; Wed, 9 Jul 2014 15:44:54 +0000 (UTC) From: aledsage To: dev@brooklyn.incubator.apache.org Reply-To: dev@brooklyn.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-brooklyn pull request: OSGi/catalog improvements Content-Type: text/plain Message-Id: <20140709154454.B48F69A9BEB@tyr.zones.apache.org> Date: Wed, 9 Jul 2014 15:44:54 +0000 (UTC) X-Virus-Checked: Checked by ClamAV on apache.org Github user aledsage commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/47#discussion_r14717238 --- Diff: core/src/main/java/brooklyn/util/ResourceUtils.java --- @@ -95,13 +113,16 @@ public static final ResourceUtils create() { } public ResourceUtils(ClassLoader loader, Object contextObject, String contextMessage) { + } --- End diff -- Looks wrong; this constructor now does nothing! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---