Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: aledsage <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-51-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-51-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Improvements to the jsgui
 catalog...
Content-Type: text/plain
Message-Id: <20140709125427.5336B9A9558@tyr.zones.apache.org>
Date: Wed,  9 Jul 2014 12:54:27 +0000 (UTC)

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/51#discussion_r14707450
  
    --- Diff: usage/rest-server/src/main/java/brooklyn/rest/resources/CatalogResource.java ---
    @@ -108,16 +102,17 @@ public CatalogEntitySummary getEntity(String entityId) throws Exception {
         }
     
         @Override
    -    public List<CatalogItemSummary> listPolicies(
    -            final String regex,
    -            final String fragment
    -    ) {
    +    public CatalogEntitySummary getApplication(String applicationId) throws Exception {
    --- End diff --
    
    Why add `throws Exception` - you removed it from `getEntity()`, which this method delegates to.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---