brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: make server pool test wait for me...
Date Fri, 11 Jul 2014 06:25:29 GMT
GitHub user ahgittin opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/64

    make server pool test wait for membership to catch up

    before making assertions, as resize happens in bg (whereas start is immediate)
    
    fixes http://brooklyn.builds.cloudsoftcorp.com/job/Brooklyn-Master-Build/io.brooklyn$brooklyn-software-base/418/testReport/junit/brooklyn.entity.pool/ServerPoolTest/testResizingPoolUp/
    
    (confirmed by inserting a sleep in `ServerPoolImpl.serverAdded` which triggers the failure
before this fix is applied)
    
    maybe we want instead to change `resize` to wait for membership to catch up?  i wasn't
sure...

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahgittin/incubator-brooklyn fix/server-pool-test-not-immediate

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/64.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #64
    
----
commit ce8d19c9348797724ab9d9915b3a8627379a6bc6
Author: Alex Heneveld <alex.heneveld@cloudsoftcorp.com>
Date:   2014-07-11T06:23:06Z

    make server pool test wait for membership to catch up before making assertions, as resize
happens in bg (whereas start is immediate)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message