brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] incubator-brooklyn pull request: OSGi/catalog improvements 2
Date Wed, 09 Jul 2014 21:06:37 GMT
GitHub user aledsage opened a pull request:

    OSGi/catalog improvements 2


You can merge this pull request into a Git repository by running:

    $ git pull ahgittin-copy/osgi

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #60
commit cebbe2b2a27e47431c1e3f4ed384132317de0261
Author: Alex Heneveld <>
Date:   2014-07-04T09:56:03Z

    address @sjcorbett review comments on #46

commit bc8b24c2cb8d6170599f950315370436ded908c4
Author: Alex Heneveld <>
Date:   2014-07-04T11:46:24Z

    stricter coercion of booleans (previously treated everything but 'true' case-insensitive
as false)

commit 51954531444ca8b881fdb17e6464f54dda9e7aa0
Author: Alex Heneveld <>
Date:   2014-07-04T11:47:01Z

    the BrooklynAssemblyTemplateInstantiator now creates a spec, significantly tidying the

commit 85fe560d91c1b1728bbaa35e2ed5164b6973ba85
Author: Alex Heneveld <>
Date:   2014-07-04T12:22:03Z

    put more design, and comments, around order in which children are added vs parent set
and initializers run

commit b7223b4627b635e4553db539a3e018fb76a2a6dc
Author: Alex Heneveld <>
Date:   2014-07-04T12:23:37Z

    when app is promoted, take some of the fields set at the template level
    (but if app is not promoted, don't *reapply* things like location)

commit 6b74582101e5686511b8bf077c8bf0ec10165c0e
Author: Alex Heneveld <>
Date:   2014-07-04T13:15:14Z

    don't promote yaml apps which define initializers and brooklyn.config at the root

commit 7d0441b0f570a9f981f6fbb15b2fb33ed8ea0511
Author: Alex Heneveld <>
Date:   2014-07-04T13:15:53Z

    expand create-entity-from-spec logic so that it does two passes, one to build up the hierarchy,
and one to run initializers and policies
    (still simpler than rebind, but more complicated than it was, to support child specs with
initializers which try to access their application)

commit 27944ce3a5a781b198833399452746099bcffb51
Author: Alex Heneveld <>
Date:   2014-07-04T13:30:10Z

    fix integration test where assumption had been not notified on benign changes

commit 4f873220e49b610d105de4c0f8a972fb94b18aee
Author: Alex Heneveld <>
Date:   2014-07-04T14:51:08Z

    extend brooklyn.catalog syntax to support name, description, and icon_url, in addition
to the registered-type/id

commit 344cbcc57f3f6a37009c6722915da6521cfd682b
Author: Alex Heneveld <>
Date:   2014-07-04T15:46:29Z

    some helpers to extract exported packages from osgi

commit e3c98e6ce3a0d0acc2faa5cecc49e4d4460674bd
Author: Alex Heneveld <>
Date:   2014-07-04T15:50:05Z

    use official constant rather than magic string

commit ff791a342e64fcaad9e0498f7d65bbf4d95e53ce
Author: Svetoslav Neykov <>
Date:   2014-07-04T17:46:42Z

    Register boot brooklyn bundles found on the classpath.

commit 5def6ea9ccf4cd827b14883d3f7f9c372626a56b
Author: Svetoslav Neykov <>
Date:   2014-07-04T19:15:09Z

    Wait for OSGi framework to stop before trying to delete its cache.

commit c391c2337e0517e43b991d7d8cc36eb9193f37be
Author: Alex Heneveld <>
Date:   2014-07-05T03:46:26Z

    add BrooklynClassLoadingContext and pass it around when we are instantiating,
    fixing BrooklynComponentTemplateResolver.loadEntitySpec to use new loaders from CatalogItem.
    currently BCLC does not really pull his weight, as he is just used for instantiation and
is never combined or kept;
    but as we fix deeper bugs in trying to resolve classes from the purview of another,
    i think it will become very useful.
    (already it should be the case -- but needs testing -- that BCLC allows children to be
resolved WRT
    the parent's bundle if they are not declared as catalog items)

commit d8fae9e69910e3c7962cecdd779ebddfd3fc1646
Author: Alex Heneveld <>
Date:   2014-07-05T04:09:02Z

    fix NPE

commit a20ad25ca82e8a2019c9ecd760da3bb0949be456
Author: Alex Heneveld <>
Date:   2014-07-07T10:04:37Z

    temporary fix for yaml/java-type resolution, and notes on the better solution

commit badab1b654b005f4e3af03851d7af6f83a72aaed
Author: Svetoslav Neykov <>
Date:   2014-07-07T09:43:22Z

    Test adding an YAML OSGi backed item to the catalog and launching it using YAML.

commit ad880c6002aa25b4808c6b273dfd2eaf34a1237b
Author: Svetoslav Neykov <>
Date:   2014-07-07T09:59:56Z

    Add test - get entity definition from OSGi based YAML.

commit 65ab9f23c3987f9244bcc665a28f392eb89b02fe
Author: Alex Heneveld <>
Date:   2014-07-07T10:47:31Z

    make constant string public for use in other tests

commit 122bbbe3c909f70affd5ae144ab60f8de09ec38c
Author: Aled Sage <>
Date:   2014-07-07T15:49:22Z

    Fixing catalog listing/instantating from REST via yaml

commit 16f599f64672a4d613b4ea15c817d27ef4a6fe37
Author: Aled Sage <>
Date:   2014-07-07T18:31:53Z

    On catalog.addItem, ensure cache is updated

commit c96b4c178a93110c8eec16a281ebd0e500cb83e9
Author: Aled Sage <>
Date:   2014-07-07T18:32:18Z

    Handle catalog item referencing other catalog item

commit 266b120e729af2708e3ba28205ed4e9960fc06f5
Author: Svetoslav Neykov <>
Date:   2014-07-07T16:37:32Z

    Add project for generating a test OSGi bundle.
    The project is included as a resource, not part of the normal build cycle.

commit 38287198a0ff3ebe0b375573b21f9cc8c51bc2d4
Author: Alex Heneveld <>
Date:   2014-07-08T04:19:34Z

    remove old brooklyn-tests jar

commit 600f56cd942ac44d416377d3796a51c7da97387b
Author: Alex Heneveld <>
Date:   2014-07-08T04:26:27Z

    fix CampYamlLiteTest with Sam's suggestion to use a classpath url which we know will be

commit dfd3e0af9bc64020faef9bd1fbb866b4c7a2a662
Author: Alex Heneveld <>
Date:   2014-07-08T04:40:40Z

    fix NPE in BrooklynYamlTypeInstantiatorTest (supertype is null)

commit 27accb0171c0b4132f277406738efacafae66ce5
Author: Alex Heneveld <>
Date:   2014-07-08T05:03:25Z

    fix CatalogResourceTest failure where 1) bundle was not resolved and 2) the default classloader
was not used

commit 5675b8578603b520569366ac469339d8022b7c91
Author: Alex Heneveld <>
Date:   2014-07-08T05:48:45Z

    specify fixed (snapshot) version of osgi bundle, add an icon, and a readme saying where
they come from

commit faec6fbc992be3437bf8126a0b5ffe19d3afe169
Author: Alex Heneveld <>
Date:   2014-07-08T05:50:10Z

    switch ResourceUtils so it can use BrooklynClassLoadingContext, and extend BCLC so it
can support getResource, and use a ResourceUtils with item-specific BCLC when resolving icons,
with test in CatalogResourceTest).
    (this is just one place of many that i expect we will have to do some tweaking to ResourceUtils,
but it confirms/shows how it can be done elsewhere)

commit 69695347c6fa99b2bc9d0cd8051335d62c088b5b
Author: Alex Heneveld <>
Date:   2014-07-08T06:14:41Z

    more tests and TODOs of tests we need


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message