brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Deploy across an entire web clust...
Date Tue, 29 Jul 2014 12:37:36 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/83#discussion_r15520146
  
    --- Diff: utils/groovy/src/main/java/brooklyn/util/GroovyJavaMethods.groovy ---
    @@ -53,7 +54,7 @@ public class GroovyJavaMethods {
         }
     
         public static <T> Callable<T> callableFromRunnable(final Runnable job)
{
    -        return (job in Callable) ? callableFromClosure(job) : Executors.callable(job);
    +        return (job in Callable) ? callableFromClosure(job) : new RunnableAdapter<Object>(job,
null);
    --- End diff --
    
    Is this because `toString` isn't good for `Executors.callable(job)` result? Or is there
another reason?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message