brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Deploy across an entire web clust...
Date Mon, 28 Jul 2014 14:50:41 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/83#discussion_r15466395
  
    --- Diff: core/src/main/java/brooklyn/entity/group/DynamicCluster.java ---
    @@ -176,13 +180,19 @@
     
         /**
          * Adds a node to the cluster in a single {@link Location}
    +     *
    +     * @deprecated since 0.7.0 tricky having this on the interface as implementation
details
    --- End diff --
    
    This wasn't in 0.7.0-M1, so I'd be fine with us deleting it rather than deprecating -
https://github.com/brooklyncentral/brooklyn/blob/0.7.0-M1/core/src/main/java/brooklyn/entity/group/DynamicCluster.java
    
    @grkvlt why did you add this?
    
    It looks like most of these methods were added post-0.7.0-M1, with some in 0.7.0-M1 (also
see https://github.com/brooklyncentral/brooklyn/blob/0.6.0/core/src/main/java/brooklyn/entity/group/DynamicCluster.java).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message