brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: OSGi class loading fixes
Date Mon, 28 Jul 2014 11:59:41 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/90#discussion_r15458170
  
    --- Diff: core/src/main/java/brooklyn/management/ha/OsgiManager.java ---
    @@ -120,6 +131,11 @@ public void registerBundle(String bundleUrl) {
                 } catch (Exception e) {
                     Exceptions.propagateIfFatal(e);
                     bundleProblems.put(bundleUrlOrNameVersionString, e);
    +
    +                Throwable cause = e.getCause();
    +                if (cause != null && cause.getMessage().contains("Unresolved
constraint in bundle")) {
    +                    log.warn("Unresolved constraint.", e);
    --- End diff --
    
    Agree, better not have the stacktrace in the console, but still I would print the nested
exception's message:
    log.warn("Unresolved constraint resolving OSGi bundle "+bundleUrlOrNameVersionString+"
to load "+type+": "+cause);
    
    Not terribly proud with this code, but couldn't find a better approach to bring out this
important cause of ClassNotFoundException.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message