brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <>
Subject [GitHub] incubator-brooklyn pull request: BrooklynRestApiLauncher rework
Date Fri, 25 Jul 2014 20:24:09 GMT
Github user ahgittin commented on a diff in the pull request:
    --- Diff: usage/rest-server/src/test/java/brooklyn/rest/ ---
    @@ -250,12 +365,12 @@ public boolean accept(File dir, String name) {
                     if (result==null || mf.lastModified() > result.lastModified()) result
= mf;
    -        if (result==null) return null;
    -        return result.getAbsolutePath();
    +        if (result==null) return Optional.absent();
    --- End diff --
    in general i prefer `Maybe` because that allows you to set a nice error message, but not
needed here

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message