brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: cassandra v2 support
Date Tue, 22 Jul 2014 12:24:08 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/81#discussion_r15224206
  
    --- Diff: software/base/src/main/java/brooklyn/entity/java/JavaSoftwareProcessSshDriver.java
---
    @@ -274,7 +274,7 @@ public String getJmxContext() {
          */
         protected boolean checkForAndInstallJava6or7() {
             Optional<String> version = getCurrentJavaVersion();
    -        if (version.isPresent() && (version.get().startsWith("1.7") || version.get().startsWith("1.6")))
{
    +        if (version.isPresent() && (version.get().startsWith("1.8") || version.get().startsWith("1.7")
|| version.get().startsWith("1.6"))) {
    --- End diff --
    
    Probably shouldn't install Java 8 from a call to a method named 'install Java 6 or 7'.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message