brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Adds EntityInitializers for http ...
Date Thu, 17 Jul 2014 09:33:51 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/48#discussion_r15048208
  
    --- Diff: core/src/main/java/brooklyn/entity/effector/AddSensor.java ---
    @@ -38,12 +38,11 @@
     @Beta
     public class AddSensor<RT,T extends Sensor<RT>> implements EntityInitializer
{
         protected final T sensor;
    -    
         public static final ConfigKey<String> SENSOR_NAME = ConfigKeys.newStringConfigKey("name");
         public static final ConfigKey<Duration> SENSOR_PERIOD = ConfigKeys.newConfigKey(Duration.class,
"period", "Period, including units e.g. 1m or 5s or 200ms");
         
         // TODO
    -//    public static final ConfigKey<String> SENSOR_TYPE = ConfigKeys.newStringConfigKey("targetType");
    --- End diff --
    
    @ahgittin why was this previously commented out in your original commit? What are implications
of uncommenting it? (An example of why I and many others hate commented out code that has
no explanation!)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message