brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: make server pool test wait for me...
Date Mon, 14 Jul 2014 16:10:32 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/64#discussion_r14886549
  
    --- Diff: software/base/src/test/java/brooklyn/entity/pool/AbstractServerPoolTest.java
---
    @@ -112,6 +113,10 @@ protected void assertAvailableCountEquals(ServerPool pool, Integer
count) {
             assertEquals(pool.getAttribute(ServerPool.AVAILABLE_COUNT), count);
         }
     
    +    protected void assertAvailableCountEventuallyEquals(int count) {
    +        EntityTestUtils.assertAttributeEqualsEventually(pool, ServerPool.AVAILABLE_COUNT,
count);
    --- End diff --
    
    Would be nice to have consistency for our suffix: "equalsEventually" or "eventuallyEquals".
I'll e-mail dev@brooklyn at some point to suggest a consistent suffix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message