brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: trim string value before transfor...
Date Mon, 14 Jul 2014 09:59:18 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/66#discussion_r14870970
  
    --- Diff: core/src/main/java/brooklyn/util/flags/TypeCoercions.java ---
    @@ -326,7 +325,7 @@ public static boolean isPrimitiveOrBoxer(Class<?> type) {
         @SuppressWarnings("unchecked")
         public static <T> T stringToPrimitive(String value, Class<T> targetType)
{
             assert Primitives.allPrimitiveTypes().contains(targetType) || Primitives.allWrapperTypes().contains(targetType)
: "targetType="+targetType;
    -
    +        value = value.trim();
    --- End diff --
    
    I think you should do this after the test for Character/char, else you'll never be able
to coerce to char ' '.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message